Add zeroization for stack buffers, add test for write protect#332
Open
padelsbach wants to merge 1 commit intowolfSSL:mainfrom
Open
Add zeroization for stack buffers, add test for write protect#332padelsbach wants to merge 1 commit intowolfSSL:mainfrom
padelsbach wants to merge 1 commit intowolfSSL:mainfrom
Conversation
padelsbach
force-pushed
the
she-zeroization
branch
from
5103722 to
cc1b033
Compare
dgarske
reviewed
Apr 13, 2026
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 1 total — 1 posted, 1 skipped
Posted findings
- [Medium] Incomplete zeroization:
_LoadKey,_ExtendSeed, and_SecureBootFinishhave same sensitive stack buffers but are not zeroized —src/wh_server_she.c:445-668,1012-1074,350-406
Skipped findings
- [Medium] Incomplete zeroization:
_LoadKey,_ExtendSeed, and_SecureBootFinishhave same sensitive stack buffers but are not zeroized
Review generated by Skoll via openclaw
padelsbach
force-pushed
the
she-zeroization
branch
from
cc1b033 to
7c52b90
Compare
Contributor
Author
Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WH_SHE_FLAG_WRITE_PROTECTFixes F-2287, F-2293, F-2294, F-2295